Skip to content

CI: Build apache module on Unix - #23405

Draft
NattyNarwhal wants to merge 2 commits into
php:masterfrom
NattyNarwhal:apache-module-ci
Draft

CI: Build apache module on Unix#23405
NattyNarwhal wants to merge 2 commits into
php:masterfrom
NattyNarwhal:apache-module-ci

Conversation

@NattyNarwhal

Copy link
Copy Markdown
Member

There are no unit tests, but a smoke test is an improvement.

Note that the configure script needs httpd-the-executable to run, so not just apache2-dev is sufficiaent on Debian and Alpine.

Windows I'm unsure about; we ship the Apache module, but I haven't wired that up in CI.

Tested locally on Alpine.

Partially addresses GH-23404

@NattyNarwhal

Copy link
Copy Markdown
Member Author

Also will need to be rebased onto 8.4.

@NattyNarwhal

Copy link
Copy Markdown
Member Author

I think Clang in macOS/FreeBSD/Alpine is being a bit picky about a convention Apache uses. -Wno-missing-field-initializers?

@ndossche

Copy link
Copy Markdown
Member

I think Clang in macOS/FreeBSD/Alpine is being a bit picky about a convention Apache uses. -Wno-missing-field-initializers?

Eek, that's not a nice flag to add.
Example from https://httpd.apache.org/docs/current/developer/modguide.html shows to use {} instead of {NULL}, maybe try that instead

There are no unit tests, but a smoke test is an improvement.

Note that the configure script needs httpd-the-executable to script, so
not just apache2-dev is sufficiaent on Debian and Alpine.

Windows I'm unsure about; we ship the Apache module, but I haven't wired
that up in CI.

Tested locally on Alpine.

Partially addresses phpGH-23404
Clang will be mad with -Wmissing-field-initializers, even though Apache
itself does this. Per Nora, [use {} as documented by Apache][modguide].

[modguide]: https://httpd.apache.org/docs/current/developer/modguide.html
@NattyNarwhal

Copy link
Copy Markdown
Member Author

For Windows, I think since it does grab apache via the series stuff in php-windows-builder, it might be a matter of just adding apache2handler to the configure flags?

@shivammathur

Copy link
Copy Markdown
Member

@NattyNarwhal

For Windows, I think since it does grab apache via the series stuff in php-windows-builder, it might be a matter of just adding apache2handler to the configure flags?

Since we pass --enable-snapshot-build in Windows CI, it already builds apache2handler. That changes all no defaults to yes, (except a few exclusions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants